introduce locking to manage access & download of archive index #2971
+78
−56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
S-waiting-on-review
syphar
added
S-waiting-on-author
syphar
force-pushed
the
archive-file-lock
branch
3 times, most recently
from
0edfa0e to
32c3e94
Compare
syphar
changed the title
syphar
force-pushed
the
archive-file-lock
branch
from
32c3e94 to
d44b6e6
Compare
syphar
added
S-waiting-on-review
syphar
force-pushed
the
archive-file-lock
branch
from
d44b6e6 to
32ad76f
Compare
GuillaumeGomez
approved these changes
Nov 14, 2025
Member
GuillaumeGomez
left a comment
GuillaumeGomez
left a comment
There was a problem hiding this comment.
Although I think the read/write locks API definitely should be improved, we didn't yet come up with a better API. I'll try to dive into it later on.
github-actions
bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comes for
Also, every now and then I manually wipe the cache, and let the server re-download the files when they are accessed.
When I do that, we see regular sqlite "database image is malformed" errors, likely because of a race condition between the index download, rename and continous requests happening. All the time following requests on the same URLs that had these errors work fine.
The shared
RwLockprotects us here. Downside is that requests will queue up until the first request downloaded the archive index, and then continue. But IMO this is good behaviour.